From 39c0ba59bc82ff6763bd1d76490816fd0c9c2d7d Mon Sep 17 00:00:00 2001 From: Matthias Clasen Date: Thu, 4 Dec 2014 22:26:14 -0500 Subject: [PATCH] places sidebar: Fix the sort function When returning 1 for a pair (a,b), a sort function must return -1 for the pair (b,a), otherwise things can go badly. https://bugzilla.gnome.org/show_bug.cgi?id=739729 --- gtk/gtkplacessidebar.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/gtk/gtkplacessidebar.c b/gtk/gtkplacessidebar.c index 80426a33cc..48364d8a9f 100644 --- a/gtk/gtkplacessidebar.c +++ b/gtk/gtkplacessidebar.c @@ -3815,6 +3815,10 @@ places_sidebar_sort_func (GtkTreeModel *model, { retval = 1; } + else if (place_type_b == PLACES_CONNECT_TO_SERVER) + { + retval = -1; + } return retval; } -- 2.30.2